linux-kernel - Re: [PATCH] ASoC: max98390: Fix potential crash during param fw loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hzh9kcrzb.wl-tiwai@suse.de>
Date:   Wed, 03 Jun 2020 13:24:08 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Steve Lee <steves.lee@...imintegrated.com>
Cc:     <lgirdwood@...il.com>, <broonie@...nel.org>, <perex@...ex.cz>,
        <tiwai@...e.com>, <ckeepax@...nsource.cirrus.com>,
        <geert@...ux-m68k.org>, <rf@...nsource.wolfsonmicro.com>,
        <shumingf@...ltek.com>, <srinivas.kandagatla@...aro.org>,
        <krzk@...nel.org>, <dmurphy@...com>, <jack.yu@...ltek.com>,
        <nuno.sa@...log.com>, <linux-kernel@...r.kernel.org>,
        <alsa-devel@...a-project.org>, <ryan.lee.maxim@...il.com>,
        <ryans.lee@...imintegrated.com>, <steves.lee.maxim@...il.com>
Subject: Re: [PATCH] ASoC: max98390: Fix potential crash during param fw loading

On Wed, 03 Jun 2020 13:18:19 +0200,
Steve Lee wrote:
> 
> @@ -847,7 +861,6 @@ static int max98390_probe(struct snd_soc_component *component)
>  
>  	/* Dsm Setting */
>  	regmap_write(max98390->regmap, DSM_VOL_CTRL, 0x94);
> -	regmap_write(max98390->regmap, DSMIG_EN, 0x19);

Is this change intentional?
It wasn't mentioned in the patch description.


thanks,

Takashi