linux-kernel - RE: [PATCH] ASoC: max98390: Fix potential crash during param fw loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR11MB204724AEA2415929253525E492880@MWHPR11MB2047.namprd11.prod.outlook.com>
Date:   Wed, 3 Jun 2020 11:30:02 +0000
From:   Steve Lee <SteveS.Lee@...imintegrated.com>
To:     Takashi Iwai <tiwai@...e.de>
CC:     "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "ckeepax@...nsource.cirrus.com" <ckeepax@...nsource.cirrus.com>,
        "geert@...ux-m68k.org" <geert@...ux-m68k.org>,
        "rf@...nsource.wolfsonmicro.com" <rf@...nsource.wolfsonmicro.com>,
        "shumingf@...ltek.com" <shumingf@...ltek.com>,
        "srinivas.kandagatla@...aro.org" <srinivas.kandagatla@...aro.org>,
        "krzk@...nel.org" <krzk@...nel.org>,
        "dmurphy@...com" <dmurphy@...com>,
        "jack.yu@...ltek.com" <jack.yu@...ltek.com>,
        "nuno.sa@...log.com" <nuno.sa@...log.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "ryan.lee.maxim@...il.com" <ryan.lee.maxim@...il.com>,
        Ryan Lee <RyanS.Lee@...imintegrated.com>,
        "steves.lee.maxim@...il.com" <steves.lee.maxim@...il.com>
Subject: RE: [PATCH] ASoC: max98390: Fix potential crash during param fw
 loading

> -----Original Message-----
> From: Takashi Iwai <tiwai@...e.de>
> Sent: Wednesday, June 3, 2020 8:24 PM
> To: Steve Lee <SteveS.Lee@...imintegrated.com>
> Cc: lgirdwood@...il.com; broonie@...nel.org; perex@...ex.cz;
> tiwai@...e.com; ckeepax@...nsource.cirrus.com; geert@...ux-m68k.org;
> rf@...nsource.wolfsonmicro.com; shumingf@...ltek.com;
> srinivas.kandagatla@...aro.org; krzk@...nel.org; dmurphy@...com;
> jack.yu@...ltek.com; nuno.sa@...log.com; linux-kernel@...r.kernel.org;
> alsa-devel@...a-project.org; ryan.lee.maxim@...il.com; Ryan Lee
> <RyanS.Lee@...imintegrated.com>; steves.lee.maxim@...il.com
> Subject: Re: [PATCH] ASoC: max98390: Fix potential crash during param fw
> loading
> 
> EXTERNAL EMAIL
> 
> 
> 
> On Wed, 03 Jun 2020 13:18:19 +0200,
> Steve Lee wrote:
> >
> > @@ -847,7 +861,6 @@ static int max98390_probe(struct snd_soc_component
> *component)
> >
> >       /* Dsm Setting */
> >       regmap_write(max98390->regmap, DSM_VOL_CTRL, 0x94);
> > -     regmap_write(max98390->regmap, DSMIG_EN, 0x19);
> 
> Is this change intentional?
> It wasn't mentioned in the patch description.

 It should be another change. I will re-send the patch.

> 
> 
> thanks,
> 
> Takashi