linux-kernel - Re: [PATCH] ASoC: max98390: Fix potential crash during param fw loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 Jun 2020 12:31:45 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Steve Lee <steves.lee@...imintegrated.com>
Cc:     lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        ckeepax@...nsource.cirrus.com, geert@...ux-m68k.org,
        rf@...nsource.wolfsonmicro.com, shumingf@...ltek.com,
        srinivas.kandagatla@...aro.org, krzk@...nel.org, dmurphy@...com,
        jack.yu@...ltek.com, nuno.sa@...log.com,
        linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
        ryan.lee.maxim@...il.com, ryans.lee@...imintegrated.com,
        steves.lee.maxim@...il.com
Subject: Re: [PATCH] ASoC: max98390: Fix potential crash during param fw
 loading

On Wed, Jun 03, 2020 at 08:18:19PM +0900, Steve Lee wrote:

> +	param_start_addr = (dsm_param[0] & 0xff) | (dsm_param[1] & 0xff) << 8;
> +	param_size = (dsm_param[2] & 0xff) | (dsm_param[3] & 0xff) << 8;
> +	if (param_size > MAX98390_DSM_PARAM_MAX_SIZE ||
> +		param_start_addr < DSM_STBASS_HPF_B0_BYTE0) {
> +		dev_err(component->dev,
> +			"param fw is invalid.\n");
> +		goto err_alloc;
> +	}

This is now reading the size out of the header of the file which is good
but it should also validate that the file is big enough to have this
much data in it, otherwise it's possible to read beyond the end of the
firmware file (eg, if it got truncated somehow).  Previously the code
used the size of the file read from disk so that wasn't an issue.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)