linux-kernel - Re: [PATCH][next] ovl: fix null pointer dereference on null stack pointer on error return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOQ4uxhSKT6dE7JUKMM7Jg2T7HFfUJQFXObtPi+z2G+JxzyRSg@mail.gmail.com>
Date:   Wed, 3 Jun 2020 19:21:18 +0300
From:   Amir Goldstein <amir73il@...il.com>
To:     Colin Ian King <colin.king@...onical.com>
Cc:     Miklos Szeredi <miklos@...redi.hu>,
        overlayfs <linux-unionfs@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] ovl: fix null pointer dereference on null stack
 pointer on error return

On Wed, Jun 3, 2020 at 7:15 PM Colin Ian King <colin.king@...onical.com> wrote:
>
> On 03/06/2020 17:11, Amir Goldstein wrote:
> > On Wed, Jun 3, 2020 at 6:46 PM Colin King <colin.king@...onical.com> wrote:
> >>
> >> From: Colin Ian King <colin.king@...onical.com>
> >>
> >> There are two error return paths where the call to path_put is
> >> dereferencing the null pointer 'stack'.  Fix this by avoiding the
> >> error exit path via label 'out_err' that will lead to the path_put
> >> calls and instead just return the error code directly.
> >>
> >> Addresses-Coverity: ("Dereference after null check)"
> >> Fixes: 4155c10a0309 ("ovl: clean up getting lower layers")
> >> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> >
> >
> > Which branch is that based on?
> > Doesn't seem to apply to master nor next
>
> It was based on today's linux-next

Oh, I'm behind.
Sorry for the noise.

Thanks,
Amir.