linux-kernel - Re: [RFC 2/4] regulator: lp87565: dt: remove duplicated section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 4 Jun 2020 07:48:09 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Luca Ceresoli <luca@...aceresoli.net>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Keerthy <j-keerthy@...com>, Axel Lin <axel.lin@...ics.com>
Subject: Re: [RFC 2/4] regulator: lp87565: dt: remove duplicated section

On Thu, 04 Jun 2020, Lee Jones wrote:

> On Wed, 03 Jun 2020, Luca Ceresoli wrote:
> 
> > The "Required properties:" section is copied verbatim for each of the two
> > supported chips. In preparation to add a new chip variant make it a common
> > section and keep the two examples to differentiate between the two chips.
> > 
> > Signed-off-by: Luca Ceresoli <luca@...aceresoli.net>
> > ---
> >  .../devicetree/bindings/mfd/lp87565.txt       | 21 ++++---------------
> >  1 file changed, 4 insertions(+), 17 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/lp87565.txt b/Documentation/devicetree/bindings/mfd/lp87565.txt
> > index 41671e0dc26b..b75ae23a1ef3 100644
> > --- a/Documentation/devicetree/bindings/mfd/lp87565.txt
> > +++ b/Documentation/devicetree/bindings/mfd/lp87565.txt
> > @@ -1,7 +1,7 @@
> >  TI LP87565 PMIC MFD driver
> >  
> >  Required properties:
> > -  - compatible:	"ti,lp87565", "ti,lp87565-q1"
> > +  - compatible:		one of "ti,lp87565", "ti,lp87565-q1", "ti,lp87561-q1"
> 
> What happened to your tabbing here?
> 
> All the other entries start with a capital letter.  So should this.

This is also an MFD patch.  Please change the subject line.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog