linux-kernel - Re: [RFC 3/4] regulator: lp87565: dt: add LP87524-Q1 variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5bfe9fb4-8792-ef21-bd02-7948d74a837d@lucaceresoli.net>
Date:   Thu, 4 Jun 2020 10:44:50 +0200
From:   Luca Ceresoli <luca@...aceresoli.net>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Keerthy <j-keerthy@...com>, Axel Lin <axel.lin@...ics.com>
Subject: Re: [RFC 3/4] regulator: lp87565: dt: add LP87524-Q1 variant

Hi Lee,

On 04/06/20 08:01, Lee Jones wrote:
> On Wed, 03 Jun 2020, Luca Ceresoli wrote:
> 
>> Add the LP87524-Q1 to the lp87565 bindings document along with an example.
> 
> Keep the way to describe model numbers consistent.
> 
> I suggest LP87565 here (even though the filename is in lower case).

Ok.

>> Signed-off-by: Luca Ceresoli <luca@...aceresoli.net>
>> ---
>>  .../devicetree/bindings/mfd/lp87565.txt       | 47 ++++++++++++++++++-
> 
> This is an MFD patch.
> 
> Please change the patch subject to reflect that.

Done that here and in patch 2 as well, and also changed from "dt:" to a
"dt-bindings:" prefix. This will be in v2:

  dt-bindings: mfd: lp87565: add LP87524-Q1 variant

>>  1 file changed, 46 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/lp87565.txt b/Documentation/devicetree/bindings/mfd/lp87565.txt
>> index b75ae23a1ef3..839eac6b75c2 100644
>> --- a/Documentation/devicetree/bindings/mfd/lp87565.txt
>> +++ b/Documentation/devicetree/bindings/mfd/lp87565.txt
>> @@ -1,7 +1,8 @@
>>  TI LP87565 PMIC MFD driver
>>  
>>  Required properties:
>> -  - compatible:		one of "ti,lp87565", "ti,lp87565-q1", "ti,lp87561-q1"
>> +  - compatible:		one of "ti,lp87565", "ti,lp87565-q1", "ti,lp87561-q1",
>> +			"ti,lp87524-q1"
> 
> Maybe have 2 per line.  It would really help with my OCD!

Ok.

-- 
Luca