linux-kernel - Re: [PATCH v14 0/3] i2c: npcm7xx: add NPCM i2c controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 4 Jun 2020 08:32:22 +0000
From:   Joel Stanley <joel@....id.au>
To:     Wolfram Sang <wsa@...-dreams.de>
Cc:     Tali Perry <tali.perry1@...il.com>,
        devicetree <devicetree@...r.kernel.org>,
        Tomer Maimon <tmaimon77@...il.com>,
        Nancy Yuen <yuenn@...gle.com>,
        Avi Fishman <avifishman70@...il.com>,
        Patrick Venture <venture@...gle.com>,
        OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
        Brendan Higgins <brendanhiggins@...gle.com>, ofery@...gle.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kfting@...oton.com, Rob Herring <robh+dt@...nel.org>,
        linux-i2c@...r.kernel.org, kbuild test robot <lkp@...el.com>,
        andriy.shevchenko@...ux.intel.com,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Benjamin Fair <benjaminfair@...gle.com>
Subject: Re: [PATCH v14 0/3] i2c: npcm7xx: add NPCM i2c controller driver

On Wed, 3 Jun 2020 at 20:26, Wolfram Sang <wsa@...-dreams.de> wrote:
>
> On Wed, May 27, 2020 at 11:08:17PM +0300, Tali Perry wrote:
> > This patch set adds i2c controller support
> > for the Nuvoton NPCM Baseboard Management Controller (BMC).
> >
> > NPCM7xx includes 16 I2C controllers. This driver operates the controller.
> > This module also includes a slave mode.
> >
> > ---
> > v14 -> v13:
> >       - Fix yaml example: add missing include.
> >       - Replace all udelay to usleep_range, except one which is called from
> >         irq.
> >       - Fix compilation error (module_platfrom_init conflict).
> >       - debugfs counters always updated. Counting till max value,
> >         then stop counting.
> >       - Rename bus-frequency to clock-frequency.
> >       - Remove unused variables.
>
> I don't have time for a deeper review, but from what I can tell this
> driver is good to go and we can fix things incrementally from now on.
>
> Applied to for-next (will go into 5.8), thanks!

Thanks Wolfram. I encourage this approach to working with patches, and
especially for our vendors who are trying to do the correct thing in
mainlining their code.

Congrats Tali on getting the driver in the tree. This has a been a long journey!

Cheers,

Joel