linux-kernel - Re: [PATCH 1/2] perf tools: check libasan and libubsan in Makefile.config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200604083416.GA1283757@krava>
Date:   Thu, 4 Jun 2020 10:34:16 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org, Xuefeng Li <lixuefeng@...ngson.cn>
Subject: Re: [PATCH 1/2] perf tools: check libasan and libubsan in
 Makefile.config

On Wed, Jun 03, 2020 at 10:01:27AM +0800, Tiezhu Yang wrote:

SNIP

> > > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> > > index 12a8204..b699d21 100644
> > > --- a/tools/perf/Makefile.config
> > > +++ b/tools/perf/Makefile.config
> > > @@ -387,6 +387,12 @@ else
> > >         NO_LIBBPF := 1
> > >         NO_JVMTI := 1
> > >       else
> > > +      ifneq ($(shell ldconfig -p | grep libasan >/dev/null 2>&1; echo $$?), 0)
> > > +        msg := $(error No libasan found, please install libasan);
> > > +      endif
> > > +      ifneq ($(shell ldconfig -p | grep libubsan >/dev/null 2>&1; echo $$?), 0)
> > > +        msg := $(error No libubsan found, please install libubsan);
> > > +      endif
> > hum, would it be better to have check for this in tools/build/features?
> 
> Hi Jiri,
> 
> Thanks for your suggestion.
> 
> Do you mean that it is better to add this check at the end of file
> tools/build/Makefile.feature?

we usualy detect installed libraries via tools/build/features framework,
this looks like it could fit in there

jirka

> 
> > 
> > jirka
> > 
> > >         ifneq ($(filter s% -static%,$(LDFLAGS),),)
> > >           msg := $(error No static glibc found, please install glibc-static);
> > >         else
> > > -- 
> > > 2.1.0
> > > 
>