lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 3 Jun 2020 10:01:27 +0800 From: Tiezhu Yang <yangtiezhu@...ngson.cn> To: Jiri Olsa <jolsa@...hat.com> Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>, Mark Rutland <mark.rutland@....com>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Namhyung Kim <namhyung@...nel.org>, linux-kernel@...r.kernel.org, Xuefeng Li <lixuefeng@...ngson.cn> Subject: Re: [PATCH 1/2] perf tools: check libasan and libubsan in Makefile.config On 06/02/2020 10:15 PM, Jiri Olsa wrote: > On Tue, Jun 02, 2020 at 12:15:03PM +0800, Tiezhu Yang wrote: >> When build perf with ASan or UBSan, if libasan or libubsan can not find, >> the feature-glibc is 0 and there exists the following error log which is >> wrong, because we can find gnu/libc-version.h in /usr/include, glibc-devel >> is also installed. >> >> [yangtiezhu@...ux perf]$ make DEBUG=1 EXTRA_CFLAGS='-fno-omit-frame-pointer -fsanitize=address' >> BUILD: Doing 'make -j4' parallel build >> HOSTCC fixdep.o >> HOSTLD fixdep-in.o >> LINK fixdep >> <stdin>:1:0: warning: -fsanitize=address and -fsanitize=kernel-address are not supported for this target >> <stdin>:1:0: warning: -fsanitize=address not supported for this target >> >> Auto-detecting system features: >> ... dwarf: [ OFF ] >> ... dwarf_getlocations: [ OFF ] >> ... glibc: [ OFF ] >> ... gtk2: [ OFF ] >> ... libaudit: [ OFF ] >> ... libbfd: [ OFF ] >> ... libcap: [ OFF ] >> ... libelf: [ OFF ] >> ... libnuma: [ OFF ] >> ... numa_num_possible_cpus: [ OFF ] >> ... libperl: [ OFF ] >> ... libpython: [ OFF ] >> ... libcrypto: [ OFF ] >> ... libunwind: [ OFF ] >> ... libdw-dwarf-unwind: [ OFF ] >> ... zlib: [ OFF ] >> ... lzma: [ OFF ] >> ... get_cpuid: [ OFF ] >> ... bpf: [ OFF ] >> ... libaio: [ OFF ] >> ... libzstd: [ OFF ] >> ... disassembler-four-args: [ OFF ] >> >> Makefile.config:393: *** No gnu/libc-version.h found, please install glibc-dev[el]. Stop. >> Makefile.perf:224: recipe for target 'sub-make' failed >> make[1]: *** [sub-make] Error 2 >> Makefile:69: recipe for target 'all' failed >> make: *** [all] Error 2 >> [yangtiezhu@...ux perf]$ ls /usr/include/gnu/libc-version.h >> /usr/include/gnu/libc-version.h >> >> After install libasan and libubsan, the feature-glibc is 1 and the build >> process is success, so the cause is related with libasan or libubsan, we >> should check them and print an error log to reflect the reality. >> >> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn> >> --- >> tools/perf/Makefile.config | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config >> index 12a8204..b699d21 100644 >> --- a/tools/perf/Makefile.config >> +++ b/tools/perf/Makefile.config >> @@ -387,6 +387,12 @@ else >> NO_LIBBPF := 1 >> NO_JVMTI := 1 >> else >> + ifneq ($(shell ldconfig -p | grep libasan >/dev/null 2>&1; echo $$?), 0) >> + msg := $(error No libasan found, please install libasan); >> + endif >> + ifneq ($(shell ldconfig -p | grep libubsan >/dev/null 2>&1; echo $$?), 0) >> + msg := $(error No libubsan found, please install libubsan); >> + endif > hum, would it be better to have check for this in tools/build/features? Hi Jiri, Thanks for your suggestion. Do you mean that it is better to add this check at the end of file tools/build/Makefile.feature? > > jirka > >> ifneq ($(filter s% -static%,$(LDFLAGS),),) >> msg := $(error No static glibc found, please install glibc-static); >> else >> -- >> 2.1.0 >>
Powered by blists - more mailing lists