lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 4 Jun 2020 21:52:55 +0800 From: Zhou Wang <wangzhou1@...ilicon.com> To: Herbert Xu <herbert@...dor.apana.org.au>, Zhangfei Gao <zhangfei.gao@...aro.org> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jonathan Cameron <Jonathan.Cameron@...wei.com>, <linux-kernel@...r.kernel.org>, <linux-crypto@...r.kernel.org>, <kbuild-all@...ts.01.org> Subject: Re: [PATCH] crypto: hisilicon - fix strncpy warning with strlcpy On 2020/6/4 14:50, Herbert Xu wrote: > On Thu, Jun 04, 2020 at 02:44:16PM +0800, Zhangfei Gao wrote: >> >> I think it is fine. >> 1. Currently the name size is 64, bigger enough. >> Simply grep in driver name, 64 should be enough. >> We can make it larger when there is a request. >> 2. it does not matter what the name is, since it is just an interface. >> cat /sys/class/uacce/hisi_zip-0/flags >> cat /sys/class/uacce/his-0/flags >> should be both fine to app only they can be distinguished. >> 3. It maybe a hard restriction to fail just because of a long name. > > I think we should err on the side of caution. IOW, unless you > know that you need it to succeed when it exceeds the limit, then > you should just make it fail. Yes. We need make it fail to avoid silent truncation. > > Thanks, >
Powered by blists - more mailing lists