linux-kernel - RE: [PATCH] scsi: storvsc: Remove memset before memory freeing in storvsc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 Jun 2020 08:07:55 +0000
From:   Dexuan Cui <decui@...rosoft.com>
To:     Denis Efremov <efremov@...ux.com>,
        Michael Kelley <mikelley@...rosoft.com>
CC:     "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        Linux SCSI List <linux-scsi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi: storvsc: Remove memset before memory freeing in
 storvsc_suspend()

> From: Denis Efremov <efremov@...ux.com>
> Sent: Friday, June 5, 2020 1:00 AM
> To: Dexuan Cui <decui@...rosoft.com>; Michael Kelley
> <mikelley@...rosoft.com>
> Cc: Denis Efremov <efremov@...ux.com>; James E . J . Bottomley
> <jejb@...ux.ibm.com>; Martin K . Petersen <martin.petersen@...cle.com>;
> linux-hyperv@...r.kernel.org; Linux SCSI List <linux-scsi@...r.kernel.org>;
> Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
> Subject: [PATCH] scsi: storvsc: Remove memset before memory freeing in
> storvsc_suspend()
> 
> Remove memset with 0 for stor_device->stor_chns in storvsc_suspend()
> before the call to kfree() as the memory contains no sensitive information.
> 
> Fixes: 56fb10585934 ("scsi: storvsc: Add the support of hibernation")
> Suggested-by: Dexuan Cui <decui@...rosoft.com>
> Signed-off-by: Denis Efremov <efremov@...ux.com>
> ---
>  drivers/scsi/storvsc_drv.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 072ed8728657..2d90cddd8ac2 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -2035,9 +2035,6 @@ static int storvsc_suspend(struct hv_device
> *hv_dev)
> 
>  	vmbus_close(hv_dev->channel);
> 
> -	memset(stor_device->stor_chns, 0,
> -	       num_possible_cpus() * sizeof(void *));
> -
>  	kfree(stor_device->stor_chns);
>  	stor_device->stor_chns = NULL;
> 
> --

Denis, thank you for fixing this!

Reviewed-by: Dexuan Cui <decui@...rosoft.com>