linux-kernel - Re: block: Fix use-after-free in blkdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200605115158.GD19604@bombadil.infradead.org>
Date:   Fri, 5 Jun 2020 04:51:58 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     linux-block@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Jason Yan <yanaijie@...wei.com>, hulkci@...wei.com,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Al Viro <viro@...iv.linux.org.uk>,
        Christoph Hellwig <hch@....de>, Jan Kara <jack@...e.cz>,
        Jens Axboe <axboe@...nel.dk>, Ming Lei <ming.lei@...hat.com>
Subject: Re: block: Fix use-after-free in blkdev_get()

On Fri, Jun 05, 2020 at 01:48:43PM +0200, Markus Elfring wrote:
> >> I am trying to contribute a bit of patch review as usual.
> >
> > Please stop criticising people's commit messages.  Your suggestions
> > are usually not improvements.
> 
> The details can vary also for my suggestions.
> Would you point any more disagreemnents out on concrete items?

That's exactly the problem with many of your comments.  They're
vague to the point of unintelligibility.

> > But refcount -> reference count is not particularly interesting.
> 
> Can a wording clarification become helpful also for this issue?

This is a great example.  I have no idea what this sentence means.
I speak some German; how would you say this in German?