linux-kernel - Re: [PATCH RESEND] lib: fix bitmap_parse() on 64-bit big endian archs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200605132558.GM2428291@smile.fi.intel.com>
Date:   Fri, 5 Jun 2020 16:25:58 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Alexander Gordeev <agordeev@...ux.ibm.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-s390@...r.kernel.org, Stable <stable@...r.kernel.org>,
        Yury Norov <yury.norov@...il.com>,
        Amritha Nambiar <amritha.nambiar@...el.com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Chris Wilson <chris@...is-wilson.co.uk>,
        Kees Cook <keescook@...omium.org>,
        Matthew Wilcox <willy@...radead.org>,
        Miklos Szeredi <mszeredi@...hat.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        "Tobin C . Harding" <tobin@...nel.org>,
        Vineet Gupta <vineet.gupta1@...opsys.com>,
        Will Deacon <will.deacon@....com>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH RESEND] lib: fix bitmap_parse() on 64-bit big endian archs

On Tue, Jun 02, 2020 at 12:24:31PM +0200, Alexander Gordeev wrote:
> On Mon, May 18, 2020 at 01:50:59PM +0200, Alexander Gordeev wrote:
> > On Mon, May 18, 2020 at 02:33:43PM +0300, Andy Shevchenko wrote:
> > > On Mon, May 18, 2020 at 1:40 PM Alexander Gordeev
> > > <agordeev@...ux.ibm.com> wrote:
> > > >
> > > > Commit 2d6261583be0 ("lib: rework bitmap_parse()") does
> > > > not take into account order of halfwords on 64-bit big
> > > > endian architectures.
> > > 
> > > Thanks for report and the patch!
> > > 
> > > Did it work before? Can we have a test case for that that we will see
> > > the failure?
> > 
> > The test exists and enabled with CONFIG_TEST_BITMAP.
> > It does not appear ever passed before on 64 BE.
> > It does not fail on 64 LE for me either.
> 
> Hi Andy et al,
> 
> Any feedback on the fix? Does it work on 64 LE for you?

Test case, please.

Yes, you can simulate BE test case on LE platform and vise versa.

-- 
With Best Regards,
Andy Shevchenko