linux-kernel - Re: [PATCH RESEND] lib: fix bitmap_parse() on 64-bit big endian archs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200608102801.GA22989@oc3871087118.ibm.com>
Date:   Mon, 8 Jun 2020 12:28:02 +0200
From:   Alexander Gordeev <agordeev@...ux.ibm.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-s390@...r.kernel.org, Stable <stable@...r.kernel.org>,
        Yury Norov <yury.norov@...il.com>,
        Amritha Nambiar <amritha.nambiar@...el.com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Chris Wilson <chris@...is-wilson.co.uk>,
        Kees Cook <keescook@...omium.org>,
        Matthew Wilcox <willy@...radead.org>,
        Miklos Szeredi <mszeredi@...hat.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        "Tobin C . Harding" <tobin@...nel.org>,
        Vineet Gupta <vineet.gupta1@...opsys.com>,
        Will Deacon <will.deacon@....com>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH RESEND] lib: fix bitmap_parse() on 64-bit big endian archs

On Fri, Jun 05, 2020 at 04:25:58PM +0300, Andy Shevchenko wrote:
> Test case, please.

Hi Andy,

Below is the output of the runtime kernel test "test_bitmap".
I resent the patch with Andrew Morton on CC, but did not include
the excessive test output:

test_bitmap: parse: 4: input is 1, result is 0x100000000, expected 0x1
test_bitmap: parse: 5: input is deadbeef, result is 0xdeadbeef00000000, expected 0xdeadbeef
test_bitmap: parse: 6: input is 1,0, result is 0x1, expected 0x100000000
test_bitmap: parse: 7: input is deadbeef,,0,1, result is 0x1, expected 0xdeadbeef
test_bitmap: parse: 8: input is deadbeef,1,0, result is 0x1, expected 0x100000000
test_bitmap: parse: 9: input is baadf00d,deadbeef,1,0, result is 0x1, expected 0x100000000
test_bitmap: parse: 10: input is badf00d,deadbeef,1,0, errno is -75, expected 0
test_bitmap: parse: 11: input is badf00d,deadbeef,1,0, errno is -75, expected 0
test_bitmap: parse: 12: input is   badf00d,deadbeef,1,0  , errno is -75, expected 0
test_bitmap: parse: 13: input is  , badf00d,deadbeef,1,0 , , errno is -75, expected 0
test_bitmap: parse: 14: input is  , badf00d, ,, ,,deadbeef,1,0 , , errno is -75, expected 0
test_bitmap: parse: 16: input is 3,0, errno is 0, expected -75
test_bitmap: parse_user: 4: input is 1, result is 0x100000000, expected 0x1
test_bitmap: parse_user: 5: input is deadbeef, result is 0xdeadbeef00000000, expected 0xdeadbeef
test_bitmap: parse_user: 6: input is 1,0, result is 0x1, expected 0x100000000
test_bitmap: parse_user: 7: input is deadbeef,,0,1, result is 0x1, expected 0xdeadbeef
test_bitmap: parse_user: 8: input is deadbeef,1,0, result is 0x1, expected 0x100000000
test_bitmap: parse_user: 9: input is baadf00d,deadbeef,1,0, result is 0x1, expected 0x100000000
test_bitmap: parse_user: 10: input is badf00d,deadbeef,1,0, errno is -75, expected 0
test_bitmap: parse_user: 11: input is badf00d,deadbeef,1,0, errno is -75, expected 0
test_bitmap: parse_user: 12: input is   badf00d,deadbeef,1,0  , errno is -75, expected 0
test_bitmap: parse_user: 13: input is  , badf00d,deadbeef,1,0 , , errno is -75, expected 0
test_bitmap: parse_user: 14: input is  , badf00d, ,, ,,deadbeef,1,0 , , errno is -75, expected 0
test_bitmap: parse_user: 16: input is 3,0, errno is 0, expected -75

Thanks!


> Yes, you can simulate BE test case on LE platform and vise versa.
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>