linux-kernel - Re: [PATCH v4] block: Fix use-after-free in blkdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+icZUUks4oJGJLhiRLTJTzyNxfsT_TZQ12MMvBVLXSaR8t0zA@mail.gmail.com>
Date:   Mon, 8 Jun 2020 08:47:11 +0200
From:   Sedat Dilek <sedat.dilek@...il.com>
To:     Christoph Hellwig <hch@....de>
Cc:     Jason Yan <yanaijie@...wei.com>, viro@...iv.linux.org.uk,
        axboe@...nel.dk, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        Ming Lei <ming.lei@...hat.com>, Jan Kara <jack@...e.cz>,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH v4] block: Fix use-after-free in blkdev_get()

On Mon, Jun 8, 2020 at 8:18 AM Christoph Hellwig <hch@....de> wrote:
>
> Looks good,
>
> Reviewed-by: Christoph Hellwig <hch@....de>
>
> Can you dig into the history for a proper fixes tag?

[ CC Dan ]

Dan gave the hint for the Fixes: tag in reply to the first patch:

> The Fixes tag is a good idea though:
>
> Fixes: 89e524c04fa9 ("loop: Fix mount(2) failure due to race with LOOP_SET_FD")

> It broke last July.  Before that, we used to check if __blkdev_get()
> failed before dereferencing "bdev".

- Sedat -