linux-kernel - Re: [PATCH v3 2/2] phy: intel: Add Keem Bay eMMC PHY support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Jun 2020 13:07:54 +0300
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@...el.com>
Cc:     kishon@...com, vkoul@...nel.org, robh+dt@...nel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        adrian.hunter@...el.com
Subject: Re: [PATCH v3 2/2] phy: intel: Add Keem Bay eMMC PHY support

On Mon, Jun 08, 2020 at 04:15:01PM +0800, Wan Ahmad Zainie wrote:
> Add support for eMMC PHY on Intel Keem Bay SoC.

I think I commented on something already.

...

> +	if (ret) {
> +		dev_err(&phy->dev, "dllrdy failed, ret=%d\n", ret);

> +		return ret;
> +	}
> +
> +	return 0;

return ret;

...

> +	if (IS_ERR(priv->emmcclk)) {
> +		dev_err(&phy->dev, "ERROR: getting emmcclk\n");

> +		return PTR_ERR(priv->emmcclk);
> +	}
> +
> +	return 0;

return PTR_ERR_OR_ZERO(...);

...

> +	priv->syscfg = devm_regmap_init_mmio(dev, base,
> +					     &keembay_regmap_config);

One line.

-- 
With Best Regards,
Andy Shevchenko