linux-kernel - RE: [PATCH v3 2/2] phy: intel: Add Keem Bay eMMC PHY support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB3721F0D18434843D1B074623DD850@DM6PR11MB3721.namprd11.prod.outlook.com>
Date:   Mon, 8 Jun 2020 10:37:25 +0000
From:   "Wan Mohamad, Wan Ahmad Zainie" 
        <wan.ahmad.zainie.wan.mohamad@...el.com>
To:     "Shevchenko, Andriy" <andriy.shevchenko@...el.com>
CC:     "kishon@...com" <kishon@...com>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "Hunter, Adrian" <adrian.hunter@...el.com>
Subject: RE: [PATCH v3 2/2] phy: intel: Add Keem Bay eMMC PHY support



> -----Original Message-----
> From: Shevchenko, Andriy <andriy.shevchenko@...el.com>
> Sent: Monday, June 8, 2020 6:08 PM
> To: Wan Mohamad, Wan Ahmad Zainie
> <wan.ahmad.zainie.wan.mohamad@...el.com>
> Cc: kishon@...com; vkoul@...nel.org; robh+dt@...nel.org; linux-
> kernel@...r.kernel.org; devicetree@...r.kernel.org; Hunter, Adrian
> <adrian.hunter@...el.com>
> Subject: Re: [PATCH v3 2/2] phy: intel: Add Keem Bay eMMC PHY support
> 
> On Mon, Jun 08, 2020 at 04:15:01PM +0800, Wan Ahmad Zainie wrote:
> > Add support for eMMC PHY on Intel Keem Bay SoC.
> 
> I think I commented on something already.

I don't recall any. May be on other similar patches.
I will wait for few days before sending next revision, if it is okay with you.

> 
> ...
> 
> > +	if (ret) {
> > +		dev_err(&phy->dev, "dllrdy failed, ret=%d\n", ret);
> 
> > +		return ret;
> > +	}
> > +
> > +	return 0;
> 
> return ret;

I will change in next revision.

> 
> ...
> 
> > +	if (IS_ERR(priv->emmcclk)) {
> > +		dev_err(&phy->dev, "ERROR: getting emmcclk\n");
> 
> > +		return PTR_ERR(priv->emmcclk);
> > +	}
> > +
> > +	return 0;
> 
> return PTR_ERR_OR_ZERO(...);

To clarify, I should replace the block above with,
return PTR_ERR_OR_ZERO(priv->emmcclk);

> 
> ...
> 
> > +	priv->syscfg = devm_regmap_init_mmio(dev, base,
> > +					     &keembay_regmap_config);
> 
> One line.

I will change in next revision.

> 
> --
> With Best Regards,
> Andy Shevchenko
>