linux-kernel - Re: [PATCH v15 01/14] mm/page_ext: Export lookup_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <320E495A-1A3E-423B-A3E7-088004771E45@redhat.com>
Date:   Mon, 8 Jun 2020 20:15:50 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     David Hildenbrand <david@...hat.com>,
        SeongJae Park <sjpark@...zon.com>, akpm@...ux-foundation.org,
        SeongJae Park <sjpark@...zon.de>, jonathan.cameron@...wei.com,
        aarcange@...hat.com, acme@...nel.org,
        alexander.shishkin@...ux.intel.com, amit@...nel.org,
        benh@...nel.crashing.org, brendan.d.gregg@...il.com,
        brendanhiggins@...gle.com, cai@....pw, colin.king@...onical.com,
        corbet@....net, dwmw@...zon.com, foersleo@...zon.de,
        irogers@...gle.com, jolsa@...hat.com, kirill@...temov.name,
        mark.rutland@....com, mgorman@...e.de, minchan@...nel.org,
        mingo@...hat.com, namhyung@...nel.org, peterz@...radead.org,
        rdunlap@...radead.org, riel@...riel.com, rientjes@...gle.com,
        rostedt@...dmis.org, sblbir@...zon.com, shakeelb@...gle.com,
        shuah@...nel.org, sj38.park@...il.com, snu@...zon.de,
        vbabka@...e.cz, vdavydov.dev@...il.com, yang.shi@...ux.alibaba.com,
        ying.huang@...el.com, linux-damon@...zon.com, linux-mm@...ck.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v15 01/14] mm/page_ext: Export lookup_page_ext() to GPL modules



> Am 08.06.2020 um 18:11 schrieb Christoph Hellwig <hch@...radead.org>:
> 
> On Mon, Jun 08, 2020 at 01:53:23PM +0200, David Hildenbrand wrote:
>>> @@ -131,6 +131,7 @@ struct page_ext *lookup_page_ext(const struct page *page)
>>>                    MAX_ORDER_NR_PAGES);
>>>    return get_entry(base, index);
>>> }
>>> +EXPORT_SYMBOL_GPL(lookup_page_ext);
>>> 
>>> static int __init alloc_node_page_ext(int nid)
>>> {
>>> 
>> 
>> I've been told to always smuggle new EXPORTs into the patch that
>> actually needs it (and cc relevant people on that patch instead).
> 
> A separate patch for anything remotely controversial really helps it
> to stick out, so I think keeping it separate is a very good practice.
> 

That used to be my approach until Michal told me to do it differently. And there is a good point for it: Reviewers actually understand in which context it is used and if it is really required.

Having that said, I don‘t have a strong opinion on this.