linux-kernel - Re: [PATCH] x86/xen: Fix a -Wmissing prototypes warning for xen_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 8 Jun 2020 21:42:45 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Boris Ostrovsky <boris.ostrovsky@...cle.com>
Cc:     Benjamin Thiel <b.thiel@...teo.de>,
        Juergen Gross <jgross@...e.com>, x86 ML <x86@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/xen: Fix a -Wmissing prototypes warning for
 xen_start_kernel()

On Mon, Jun 08, 2020 at 03:30:13PM -0400, Boris Ostrovsky wrote:
> TBH I am not sure it's worth a new header file for a routine that is
> only called from assembly (and never returns). I'd just add the
> prototype right above function definition, with a comment describing
> why. 

Right, that works too.

> I see a few examples of this in the tree. Or maybe we even have an
> attribute for this case?

Not that I'm aware of.

> (I also suspect the same may be needed for xen_prepare_pvh() BTW).

Yeah, Benni is working through the rest of them. Btw, the final goal of
this whole work is to enable -Wmissing-prototypes by default on x86.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette