linux-kernel - Re: [PATCH] x86/xen: Fix a -Wmissing prototypes warning for xen_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21d6821e-e488-138e-a0be-2177c4aa13b2@oracle.com>
Date:   Mon, 8 Jun 2020 15:30:13 -0400
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Benjamin Thiel <b.thiel@...teo.de>, Borislav Petkov <bp@...en8.de>,
        Juergen Gross <jgross@...e.com>
Cc:     x86 ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/xen: Fix a -Wmissing prototypes warning for
 xen_start_kernel()

On 6/6/20 10:27 AM, Benjamin Thiel wrote:
> Fix:
>
>   arch/x86/xen/enlighten_pv.c:1212:34:
>   warning: no previous prototype for ‘xen_start_kernel’ [-Wmissing-prototypes]
>   asmlinkage __visible void __init xen_start_kernel(void)
>
> Add a prototype for xen_start_kernel() in a separate xen-specific header.

TBH I am not sure it's worth a new header file for a routine that is
only called from assembly (and never returns). I'd just add the
prototype right above function definition, with a comment describing
why. I see a few examples of this in the tree. Or maybe we even have an
attribute for this case?

(I also suspect the same may be needed for xen_prepare_pvh() BTW).

-boris