linux-kernel - [PATCH] integrity: Remove redundant variable assignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20200609125334.15764-1-tianjia.zhang@linux.alibaba.com>
Date:   Tue,  9 Jun 2020 20:53:34 +0800
From:   Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
To:     jmorris@...ei.org, serge@...lyn.com, dhowells@...hat.com,
        nramas@...ux.microsoft.com, tusharsu@...ux.microsoft.com,
        zohar@...ux.ibm.com
Cc:     linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, tianjia.zhang@...ux.alibaba.com
Subject: [PATCH] integrity: Remove redundant variable assignments

The local variable `ret` will be assigned when it is used
for the first time, and assignment is not necessary when
the variable is declared.

Signed-off-by: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
---
 security/integrity/digsig_asymmetric.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/integrity/digsig_asymmetric.c b/security/integrity/digsig_asymmetric.c
index 4e0d6778277e..cfa4127d0518 100644
--- a/security/integrity/digsig_asymmetric.c
+++ b/security/integrity/digsig_asymmetric.c
@@ -79,7 +79,7 @@ int asymmetric_verify(struct key *keyring, const char *sig,
 	struct public_key_signature pks;
 	struct signature_v2_hdr *hdr = (struct signature_v2_hdr *)sig;
 	struct key *key;
-	int ret = -ENOMEM;
+	int ret;
 
 	if (siglen <= sizeof(*hdr))
 		return -EBADMSG;
-- 
2.17.1