linux-kernel - Re: [PATCH AUTOSEL 4.14 72/72] string.h: fix incompatibility between FORTIFY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200609135517.GA4806@amd>
Date:   Tue, 9 Jun 2020 15:55:17 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Daniel Axtens <dja@...ens.net>, Sasha Levin <sashal@...nel.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Gow <davidgow@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Daniel Micay <danielmicay@...il.com>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Alexander Potapenko <glider@...gle.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH AUTOSEL 4.14 72/72] string.h: fix incompatibility between
 FORTIFY_SOURCE and KASAN

On Tue 2020-06-09 13:54:07, Greg KH wrote:
> On Tue, Jun 09, 2020 at 01:20:25PM +0200, Pavel Machek wrote:
> > On Tue 2020-06-09 09:46:08, Daniel Axtens wrote:
> > > Hi Sasha,
> > > 
> > > There's nothing inherently wrong with these patches being backported,
> > > but they fix a bug that doesn't cause a crash and only affects debug
> > > kernels compiled with KASAN and FORTIFY_SOURCE. Personally I wouldn't
> > > change a core header file in a stable kernel for that. Perhaps I'm too
> > > risk-averse.
> > 
> > You are in agreement with existing documentation -- stable is only for
> > serious bugs.
> 
> No, lots of people run KASAN on those kernels when they are testing
> their devices, this patch is fine.

Documentation currently says:

 - It must fix a problem that causes a build error (but not for things
    marked CONFIG_BROKEN), an oops, a hang, data corruption, a real
    security issue, or some "oh, that's not good" issue.  In short,
    something critical.

...but we also get various warning fixes (sometimes for external
tools), changes to make printk()s less verbose, changes to make
debugging easier, etc...

Could the documentation be updated to match current use?

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)