linux-kernel - Re: [PATCH v1 2/2] usb: phy: Add USB3 PHY support for Intel LGM SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202006092114.Xe5N9vBs%lkp@intel.com>
Date:   Tue, 9 Jun 2020 21:11:28 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Ramuthevar, Vadivel MuruganX" 
        <vadivel.muruganx.ramuthevar@...ux.intel.com>,
        linux-kernel@...r.kernel.org, balbi@...nel.org
Cc:     kbuild-all@...ts.01.org, gregkh@...uxfoundation.org,
        robh@...nel.org, devicetree@...r.kernel.org,
        p.zabel@...gutronix.de, linux-usb@...r.kernel.org,
        cheol.yong.kim@...el.com, qi-ming.wu@...el.com, yin1.li@...el.com
Subject: Re: [PATCH v1 2/2] usb: phy: Add USB3 PHY support for Intel LGM SoC

Hi "Ramuthevar,Vadivel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on balbi-usb/testing/next]
[also build test WARNING on usb/usb-testing linus/master v5.7 next-20200608]
[cannot apply to linux/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Ramuthevar-Vadivel-MuruganX/usb-phy-Add-USB-PHY-support-on-Intel-LGM-SoC/20200609-191216
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

drivers/usb/phy/phy-lgm-usb.c: In function 'phy_init':
>> drivers/usb/phy/phy-lgm-usb.c:79:13: warning: passing argument 1 of 'IS_ERR' makes pointer from integer without a cast [-Wint-conversion]
79 |  if (IS_ERR(ret)) {
|             ^~~
|             |
|             int
In file included from include/linux/io.h:12,
from include/linux/iopoll.h:14,
from drivers/usb/phy/phy-lgm-usb.c:10:
include/linux/err.h:34:60: note: expected 'const void *' but argument is of type 'int'
34 | static inline bool __must_check IS_ERR(__force const void *ptr)
|                                                ~~~~~~~~~~~~^~~
>> drivers/usb/phy/phy-lgm-usb.c:81:18: warning: passing argument 1 of 'PTR_ERR' makes pointer from integer without a cast [-Wint-conversion]
81 |   return PTR_ERR(ret);
|                  ^~~
|                  |
|                  int
In file included from include/linux/io.h:12,
from include/linux/iopoll.h:14,
from drivers/usb/phy/phy-lgm-usb.c:10:
include/linux/err.h:29:61: note: expected 'const void *' but argument is of type 'int'
29 | static inline long __must_check PTR_ERR(__force const void *ptr)
|                                                 ~~~~~~~~~~~~^~~
drivers/usb/phy/phy-lgm-usb.c: In function 'tca_work':
drivers/usb/phy/phy-lgm-usb.c:136:30: warning: unused variable 'property' [-Wunused-variable]
136 |  union extcon_property_value property;
|                              ^~~~~~~~

vim +/IS_ERR +79 drivers/usb/phy/phy-lgm-usb.c

    64	
    65	static int phy_init(struct usb_phy *phy)
    66	{
    67		struct tca_apb *ta = container_of(phy, struct tca_apb, phy);
    68		void __iomem *ctrl1 = phy->io_priv + CTRL1_OFFSET;
    69		int val, ret, i;
    70	
    71		if (ta->phy_initialized)
    72			return 0;
    73	
    74		for (i = 0; i < ARRAY_SIZE(PHY_RESETS); i++)
    75			reset_control_deassert(ta->resets[i]);
    76	
    77		ret = readl_poll_timeout(ctrl1, val, val & SRAM_INIT_DONE,
    78					 10, 10 * 1000);
  > 79		if (IS_ERR(ret)) {
    80			dev_err(ta->phy.dev, "SRAM init failed, 0x%x\n", val);
  > 81			return PTR_ERR(ret);
    82		}
    83	
    84		writel(readl(ctrl1) | SRAM_EXT_LD_DONE, ctrl1);
    85	
    86		ta->phy_initialized = true;
    87		if (!ta->phy.edev)
    88			return phy->set_vbus(phy, true);
    89	
    90		schedule_work(&ta->wk);
    91	
    92		return 0;
    93	}
    94	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (62542 bytes)