linux-kernel - Re: [PATCH 1/3] usb: typec: Add QCOM PMIC typec detection driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ccfc3e7c-d1ce-27bd-b24c-df5fbc468449@infradead.org>
Date:   Tue, 9 Jun 2020 14:20:37 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Wesley Cheng <wcheng@...eaurora.org>,
        heikki.krogerus@...ux.intel.com, gregkh@...uxfoundation.org,
        mark.rutland@....com, robh+dt@...nel.org, agross@...nel.org,
        bjorn.andersson@...aro.org
Cc:     linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-usb@...r.kernel.org,
        jackp@...eaurora.org, bryan.odonoghue@...aro.org
Subject: Re: [PATCH 1/3] usb: typec: Add QCOM PMIC typec detection driver

On 6/9/20 1:58 PM, Wesley Cheng wrote:
> diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig
> index 559dd06..8de2520 100644
> --- a/drivers/usb/typec/Kconfig
> +++ b/drivers/usb/typec/Kconfig
> @@ -73,6 +73,17 @@ config TYPEC_TPS6598X
>  	  If you choose to build this driver as a dynamically linked module, the
>  	  module will be called tps6598x.ko.
> 

Hi,
Please spell "Type-C" like all of the other drivers do.

> +config TYPEC_QCOM_PMIC
> +	tristate "Qualcomm PMIC USB typec driver"
> +	depends on ARCH_QCOM
> +	help
> +	  Driver for supporting role switch over the Qualcomm PMIC.  This will
> +	  handle the type C role and orientation detection reported by the QCOM
> +	  PMIC if the PMIC has the capability to handle type C detection.
> +
> +	  It will also enable the VBUS output to connected devices when a
> +	  DFP connection is made.
> +
>  source "drivers/usb/typec/mux/Kconfig"
>  
>  source "drivers/usb/typec/altmodes/Kconfig"


-- 
~Randy