linux-kernel - Re: [PATCH] EDAC, {skx, i10nm}: Advice mcelog that the error were handled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200610101819.oa2ivjtxildwothl@rric.localdomain>
Date:   Wed, 10 Jun 2020 12:18:19 +0200
From:   Robert Richter <rrichter@...vell.com>
To:     Zhenzhong Duan <zhenzhong.duan@...il.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-edac@...r.kernel.org>,
        <tony.luck@...el.com>, <bp@...en8.de>, <mchehab@...nel.org>,
        <james.morse@....com>
Subject: Re: [PATCH] EDAC, {skx, i10nm}: Advice mcelog that the error were
 handled

On 10.06.20 14:58:01, Zhenzhong Duan wrote:
> If one MCE error has been processed in kernel, it's not necessory
> to pass it to user level mcelog.
> 
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@...il.com>

Reviewed-by: Robert Richter <rrichter@...vell.com>

> ---
>  drivers/edac/skx_common.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/skx_common.c b/drivers/edac/skx_common.c
> index 46be1a7..8c0165b 100644
> --- a/drivers/edac/skx_common.c
> +++ b/drivers/edac/skx_common.c
> @@ -615,7 +615,8 @@ int skx_mce_check_error(struct notifier_block *nb, unsigned long val,
>  
>  	skx_mce_output_error(mci, mce, &res);
>  
> -	return NOTIFY_DONE;
> +	/* Advice mcelog that the error were handled */

... error was ...

And make a sentence out of it, so close with a dot.

> +	return NOTIFY_STOP;

This change aligns with other implementation in:

 i7core_mce_check_error(),
 amd_decode_mce() and
 sbridge_mce_check_error().

-Robert

>  }
>  
>  void skx_remove(void)
> -- 
> 1.8.3.1
>