linux-kernel - Re: [PATCH] EDAC, {skx,i10nm}: Advice mcelog that the error were handled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFH1YnNsM0okzpLru9Fd__F9yp-a00+J17L2atLBrnV3vWSqLw@mail.gmail.com>
Date:   Wed, 10 Jun 2020 16:48:26 +0800
From:   Zhenzhong Duan <zhenzhong.duan@...il.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        linux-edac@...r.kernel.org, tony.luck@...el.com,
        mchehab@...nel.org, james.morse@....com, rrichter@...vell.com
Subject: Re: [PATCH] EDAC, {skx,i10nm}: Advice mcelog that the error were handled

On Wed, Jun 10, 2020 at 4:20 PM Borislav Petkov <bp@...en8.de> wrote:
>
> On Wed, Jun 10, 2020 at 02:58:01PM +0800, Zhenzhong Duan wrote:
> > If one MCE error has been processed in kernel, it's not necessory
> > to pass it to user level mcelog.
> >
> > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@...il.com>
> > ---
> >  drivers/edac/skx_common.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/edac/skx_common.c b/drivers/edac/skx_common.c
> > index 46be1a7..8c0165b 100644
> > --- a/drivers/edac/skx_common.c
> > +++ b/drivers/edac/skx_common.c
> > @@ -615,7 +615,8 @@ int skx_mce_check_error(struct notifier_block *nb, unsigned long val,
> >
> >       skx_mce_output_error(mci, mce, &res);
> >
> > -     return NOTIFY_DONE;
> > +     /* Advice mcelog that the error were handled */
> > +     return NOTIFY_STOP;
> >  }
> >
> >  void skx_remove(void)
> > --
>
> No, we won't be doing that anymore. See here:
>
> https://git.kernel.org/tip/23ba710a0864108910c7531dc4c73ef65eca5568
>
> it should appear mainline soon-ish, I hope.

I see, thanks for showing.

Zhenzhong