linux-kernel - Re: [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1367fcf3-24ed-9106-a329-da5f8e168e17@gmail.com>
Date:   Tue, 9 Jun 2020 19:27:16 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Álvaro Fernández Rojas <noltari@...il.com>,
        mturquette@...libre.com, sboyd@...nel.org, robh+dt@...nel.org,
        f.fainelli@...il.com, bcm-kernel-feedback-list@...adcom.com,
        julia.lawall@...6.fr, f4bug@...at.org, jonas.gorski@...il.com,
        lkp@...el.com, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support



On 6/9/2020 4:30 AM, Álvaro Fernández Rojas wrote:
> +static const struct clk_bcm63xx_table_entry bcm6318_clocks[] = {
> +	{ .name = "adsl_asb", .bit = 0, },
> +	{ .name = "usb_asb", .bit = 1, },
> +	{ .name = "mips_asb", .bit = 2, },
> +	{ .name = "pcie_asb", .bit = 3, },
> +	{ .name = "phymips_asb", .bit = 4, },
> +	{ .name = "robosw_asb", .bit = 5, },
> +	{ .name = "sar_asb", .bit = 6, },
> +	{ .name = "sdr_asb", .bit = 7, },
> +	{ .name = "swreg_asb", .bit = 8, },
> +	{ .name = "periph_asb", .bit = 9, },
> +	{ .name = "cpubus160", .bit = 10, },
> +	{ .name = "adsl", .bit = 11, },
> +	{ .name = "sar124", .bit = 12, },

Nit: this should be sar125

> +	{ .name = "mips", .bit = 13, .flags = CLK_IS_CRITICAL, },
> +	{ .name = "pcie", .bit = 14, },
> +	{ .name = "robosw250", .bit = 16, },
> +	{ .name = "robosw025", .bit = 17, },
> +	{ .name = "sdr", .bit = 19, .flags = CLK_IS_CRITICAL, },
> +	{ .name = "usb", .bit = 20, },

This should probably be "usbd" to indicate this is the USB device clock
(not host)

With that fixed:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian