linux-kernel - Re: [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3E897527-55EB-47DB-99ED-C737725F0F9E@gmail.com>
Date:   Wed, 10 Jun 2020 08:12:53 +0200
From:   Álvaro Fernández Rojas <noltari@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     mturquette@...libre.com, sboyd@...nel.org, robh+dt@...nel.org,
        bcm-kernel-feedback-list@...adcom.com, julia.lawall@...6.fr,
        f4bug@...at.org, jonas.gorski@...il.com, lkp@...el.com,
        linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support

Hi Florian,

> El 10 jun 2020, a las 4:27, Florian Fainelli <f.fainelli@...il.com> escribió:
> 
> 
> 
> On 6/9/2020 4:30 AM, Álvaro Fernández Rojas wrote:
>> +static const struct clk_bcm63xx_table_entry bcm6318_clocks[] = {
>> +	{ .name = "adsl_asb", .bit = 0, },
>> +	{ .name = "usb_asb", .bit = 1, },
>> +	{ .name = "mips_asb", .bit = 2, },
>> +	{ .name = "pcie_asb", .bit = 3, },
>> +	{ .name = "phymips_asb", .bit = 4, },
>> +	{ .name = "robosw_asb", .bit = 5, },
>> +	{ .name = "sar_asb", .bit = 6, },
>> +	{ .name = "sdr_asb", .bit = 7, },
>> +	{ .name = "swreg_asb", .bit = 8, },
>> +	{ .name = "periph_asb", .bit = 9, },
>> +	{ .name = "cpubus160", .bit = 10, },
>> +	{ .name = "adsl", .bit = 11, },
>> +	{ .name = "sar124", .bit = 12, },
> 
> Nit: this should be sar125

Nice catch, I will fix this in v2.

> 
>> +	{ .name = "mips", .bit = 13, .flags = CLK_IS_CRITICAL, },
>> +	{ .name = "pcie", .bit = 14, },
>> +	{ .name = "robosw250", .bit = 16, },
>> +	{ .name = "robosw025", .bit = 17, },
>> +	{ .name = "sdr", .bit = 19, .flags = CLK_IS_CRITICAL, },
>> +	{ .name = "usb", .bit = 20, },
> 
> This should probably be "usbd" to indicate this is the USB device clock
> (not host)

Ok, I will change it. I got confused by the fact that both (usbd and usbh) were present on 6318_map_part.h:
#define USBD_CLK_EN         (1 << 20)
#define USBH_CLK_EN         (1 << 20)

> 
> With that fixed:
> 
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> -- 
> Florian