linux-kernel - Re: [PATCH 3/7] reset: add BCM6345 reset controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <41A1CC01-BFA0-48A1-A2EE-7917B3A1323A@gmail.com>
Date:   Wed, 10 Jun 2020 08:08:37 +0200
From:   Álvaro Fernández Rojas <noltari@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Philipp Zabel <p.zabel@...gutronix.de>, robh+dt@...nel.org,
        tsbogend@...ha.franken.de, Jonas Gorski <jonas.gorski@...il.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mips@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH 3/7] reset: add BCM6345 reset controller driver

Hi Florian,

> El 9 jun 2020, a las 22:17, Florian Fainelli <f.fainelli@...il.com> escribió:
> 
> 
> 
> On 6/9/2020 9:41 AM, Álvaro Fernández Rojas wrote:
>>>>> If you can do without this, with I think this driver could be made to
>>>>> use reset-simple.
>>>> 
>>>> Yes, but only if I can add reset support with a configurable sleep range to reset-simple. Is this possible?
>>> 
>>> I should have mentioned, support for this is on the reset/next branch:
>>> 
>>> git://git.pengutronix.de/pza/linux.git reset/next
>> 
>> Yes, but reset_us was only added to reset_simple_data, so there’s no way to fill that value from reset_simple_devdata or device tree, right?
> 
> Not that I can see, but you could certainly extend it here:
> 
> if (devdata) {
> 		reg_offset = devdata->reg_offset;
> 		if (devdata->nr_resets)
> 			data->rcdev.nr_resets = devdata->nr_resets;
> 		data->active_low = devdata->active_low;
> 		data->status_active_low = devdata->status_active_low;
> 	}

Yes, I would extend it there too, but I was just saying that it’s a bit strange that it was only added to reset_simple_data without any way to fill the value.

> 
> and have an appropriate devdata structure be provided for your
> compatible string:
> 
> +	{ .compatible = "brcm,bcm6345-reset", .data = bcm6345_reset_devdata },
> -- 
> Florian

Regards,
Álvaro.