lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 11 Jun 2020 23:32:57 +0000 From: Chaitanya Kulkarni <Chaitanya.Kulkarni@....com> To: Logan Gunthorpe <logang@...tatee.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org> CC: Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>, Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...com>, Max Gurtovoy <maxg@...lanox.com>, Stephen Bates <sbates@...thlin.com> Subject: Re: [PATCH v13 8/9] nvmet-passthru: Add enable/disable helpers On 6/11/20 4:15 PM, Logan Gunthorpe wrote: > Honestly, I think that is too brief. The error message is only 74 chars > and there's a long standing exception for long lines in the kernel for > printks. Even Linus has recently suggested that keeping to the 80 char > limit is not recommended when it harms readability (though I don't > generally agree with this 100%)[1]. I'm aware of that and main cause is it creates unnecessary breaking which can lead to bugs, hard to read code and ugly wrapped code. I think this case is different with printing message which is straight forward to read and not going to introduce any bugs in actual logic. Based on your earlier reply about splitting printk I'll let Christoph and Sagi decide on what to do about this and whether to enforce strict 80 lines or not for NVMe subsystem for printing messages and for future code.
Powered by blists - more mailing lists