linux-kernel - RE: [PATCH] ASoC: SOF: Intel: hda: unsolicited RIRB response

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB43168DD90582B665DF0F7D6397800@DM6PR11MB4316.namprd11.prod.outlook.com>
Date:   Thu, 11 Jun 2020 23:33:59 +0000
From:   "Lu, Brent" <brent.lu@...el.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Takashi Iwai <tiwai@...e.de>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>
CC:     "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "authored:2/16=12%,added_lines:21/248=8%,removed_lines:5/84=6%,),Liam
        Girdwood DRIVERS )" <lgirdwood@...il.com>,
        "commit_signer:6/16=38%,authored:6/16=38%,added_lines:123/248=50% 
        ,removed_lines:36/84=43%,Kai Vehmanen DRIVERS )" 
        <kai.vehmanen@...ux.intel.com>,
        "Daniel Baluta DRIVERS )" <daniel.baluta@....com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        "Rojewski, Cezary" <cezary.rojewski@...el.com>,
        Zhu Yingjiang <yingjiang.zhu@...ux.intel.com>,
        Keyon Jie <yang.jie@...ux.intel.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        "sound-open-firmware@...a-project.orgDRIVERS" 
        <sound-open-firmware@...a-project.orgDRIVERS>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ASoC: SOF: Intel: hda: unsolicited RIRB response

> 
> IIRC we added this loop before merging all interrupt handling in one thread,
> somehow the MSI mode never worked reliably without this change, so
> maybe we don't need this loop any longer.
> 
> I'd really prefer it if we didn't tie the RIRB handing change to this loop change,
> removing the loop should only be done with *a lot of testing*.

The reason I removed the loop because I thought it's for the unsolicited response,
apparently it's not. I'd like to port the commit 6d011d5057ff

    ALSA: hda: Clear RIRB status before reading WP

to SOF driver and upload a version 2. Thanks.

Regards,
Brent