[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200611085710.GV2428291@smile.fi.intel.com>
Date: Thu, 11 Jun 2020 11:57:10 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: "Ramuthevar, Vadivel MuruganX"
<vadivel.muruganx.ramuthevar@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org, balbi@...nel.org,
p.zabel@...gutronix.de, gregkh@...uxfoundation.org,
robh@...nel.org, devicetree@...r.kernel.org,
linux-usb@...r.kernel.org, cheol.yong.kim@...el.com,
qi-ming.wu@...el.com, yin1.li@...el.com
Subject: Re: [PATCH v2 2/2] usb: phy: Add USB3 PHY support for Intel LGM SoC
On Thu, Jun 11, 2020 at 04:36:29PM +0800, Ramuthevar, Vadivel MuruganX wrote:
> On 11/6/2020 4:12 pm, Andy Shevchenko wrote:
> > On Thu, Jun 11, 2020 at 10:12:46AM +0800, Ramuthevar,Vadivel MuruganX wrote:
> > > From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@...ux.intel.com>
...
> > > + ret = readl_poll_timeout(ctrl1, val, val & SRAM_INIT_DONE,
> > > + 10, 10 * 1000);
> exceeds more than 80 characters, so checkpatch throws warnings, to avoid
> that move to next line.
> > On one line easier to read.
It's 82 characters. It's fine.
> > > + if (ret) {
> > > + dev_err(ta->phy.dev, "SRAM init failed, 0x%x\n", val);
> > > + return ret;
> > > + }
...
> > > + int ret = 0;
> >
> > Assignment is redundant.
> so you mean , should be declared as
> int ret;
> right?
Right.
...
> > > + dev_info(ta->phy.dev, "connected%s\n",
> > > + flipped ? " flipped" : "");
> >
> > One line.
> exceeds more than 80 characters, so checkpatch throw warnings, to avoid that
> moved to next line.
It's fine to have on one line.
And by the way, try new checkpatch.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists