linux-kernel - Re: [PATCH v4 25/27] clk: bcm2835: Allow custom CCF flags for the PLLs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Jun 2020 11:11:00 +0200
From:   Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
To:     Maxime Ripard <maxime@...no.tech>
Cc:     Tim Gover <tim.gover@...pberrypi.com>,
        Dave Stevenson <dave.stevenson@...pberrypi.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Mike Turquette <mturquette@...libre.com>,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        linux-rpi-kernel@...ts.infradead.org,
        Phil Elwell <phil@...pberrypi.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 25/27] clk: bcm2835: Allow custom CCF flags for the
 PLLs

Hi Maxime,

On Thu, 2020-06-11 at 09:32 +0200, Maxime Ripard wrote:
> While some clock types allow for each clock to specify its own custom
> flags, the PLLs can't. We will need this for the PLLB, so let's add it.
> 
> Signed-off-by: Maxime Ripard <maxime@...no.tech>
> ---
>  drivers/clk/bcm/clk-bcm2835.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
> index 32f5c13be9d1..846ea68b2c73 100644
> --- a/drivers/clk/bcm/clk-bcm2835.c
> +++ b/drivers/clk/bcm/clk-bcm2835.c
> @@ -421,6 +421,7 @@ struct bcm2835_pll_data {
>  	u32 reference_enable_mask;
>  	/* Bit in CM_LOCK to indicate when the PLL has locked. */
>  	u32 lock_mask;
> +	u32 flags;
>  
>  	const struct bcm2835_pll_ana_bits *ana;
>  
> @@ -1310,7 +1311,7 @@ static struct clk_hw *bcm2835_register_pll(struct
> bcm2835_cprman *cprman,
>  	init.num_parents = 1;
>  	init.name = pll_data->name;
>  	init.ops = &bcm2835_pll_clk_ops;
> -	init.flags = CLK_IGNORE_UNUSED;
> +	init.flags = data->flags | CLK_IGNORE_UNUSED;

This should be 'pll_data->flags'.

With that fixed:

Acked-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>

Regards,
Nicolas


Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)