linux-kernel - Re: [LKP] [ima] 8eb613c0b8: stress-ng.icache.ops_per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1591872811.5140.41.camel@linux.ibm.com>
Date:   Thu, 11 Jun 2020 06:53:31 -0400
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Xing Zhengjun <zhengjun.xing@...ux.intel.com>,
        kernel test robot <rong.a.chen@...el.com>
Cc:     Lakshmi Ramasubramanian <nramas@...ux.microsoft.com>,
        LKML <linux-kernel@...r.kernel.org>, lkp@...ts.01.org
Subject: Re: [LKP] [ima] 8eb613c0b8: stress-ng.icache.ops_per_sec -84.2%
 regression

On Thu, 2020-06-11 at 15:10 +0800, Xing Zhengjun wrote:
> On 6/10/2020 9:53 PM, Mimi Zohar wrote:
>  	ucode: 0x500002c
> > 
> > Does the following change resolve it?
> > 
> > diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
> > index c44414a7f82e..78e1dfc8a3f2 100644
> > --- a/security/integrity/ima/ima_main.c
> > +++ b/security/integrity/ima/ima_main.c
> > @@ -426,7 +426,8 @@ int ima_file_mprotect(struct vm_area_struct *vma, unsigned long prot)
> >   	int pcr;
> >   
> >   	/* Is mprotect making an mmap'ed file executable? */
> > -	if (!vma->vm_file || !(prot & PROT_EXEC) || (vma->vm_flags & VM_EXEC))
> > +	if (!(ima_policy_flag & IMA_APPRAISE) || !vma->vm_file ||
> > +	    !(prot & PROT_EXEC) || (vma->vm_flags & VM_EXEC))
> >   		return 0;
> >   
> >   	security_task_getsecid(current, &secid);
> > 
> Thanks. I test the change, it can resolve the regression.

Thanks!  Can I get your "Tested-by" tag?

Mimi