lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 12 Jun 2020 12:02:05 +0200
From:   Greg KH <>
To:     Markus Elfring <>
Cc:     Bernard Zhao <>,,,,,,
        Daniel Vetter <>,
        David Airlie <>,
        Rob Clark <>, Sean Paul <>
Subject: Re: [PATCH] drm/msm: Fix memory leak in msm_submitqueue_create()

On Fri, Jun 12, 2020 at 11:37:33AM +0200, Markus Elfring wrote:
> > In fucntin msm_submitqueue_create, the queue is a local
> > variable, in return -EINVAL branch, queue didn`t add to ctx`s
> > list yet, and also didn`t kfree, this maybe bring in potential
> > memleak.
> I suggest to improve also this change description.
> How do you think about a wording variant like the following?
>    Release the GPU submission queue object after an input parameter validation failed.
> Would you like to add the tag “Fixes” to the commit message?
> How do you think about to reorder any statements for this function implementation?
> Regards,
> Markus


This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.


greg k-h's patch email bot

Powered by blists - more mailing lists