lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 12 Jun 2020 16:22:31 +0300
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@...el.com>
Cc:     kishon@...com, vkoul@...nel.org, robh+dt@...nel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        adrian.hunter@...el.com
Subject: Re: [PATCH v4 2/2] phy: intel: Add Keem Bay eMMC PHY support

On Fri, Jun 12, 2020 at 11:53:59AM +0800, Wan Ahmad Zainie wrote:
> Add support for eMMC PHY on Intel Keem Bay SoC.

Pretty much good, my comments below.

...

> +config PHY_KEEMBAY_EMMC
> +	tristate "Intel Keem Bay EMMC PHY Driver"

> +	depends on OF

No compile test?

> +	select GENERIC_PHY
> +	select REGMAP_MMIO
> +	help
> +	  Enable this to support the Keem Bay EMMC PHY.

Please, be more verbose here, do I, as a user, need this? What will be the module name?

-- 
With Best Regards,
Andy Shevchenko


Powered by blists - more mailing lists