lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 Jun 2020 10:00:33 -0700 From: Matthew Wilcox <willy@...radead.org> To: Markus Elfring <Markus.Elfring@....de> Cc: Kaitao Cheng <pilgrimtao@...il.com>, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org, Alexey Dobriyan <adobriyan@...il.com>, Colin Ian King <colin.king@...onical.com>, Muchun Song <songmuchun@...edance.com> Subject: Re: [PATCH v2] proc/fd: Remove unnecessary variable initialisations in seq_show() On Fri, Jun 12, 2020 at 06:45:57PM +0200, Markus Elfring wrote: > > 'files' will be immediately reassigned. 'f_flags' and 'file' will be > > overwritten in the if{} or seq_show() directly exits with an error. > > so we don't need to consume CPU resources to initialize them. > > I suggest to improve also this change description. > > * Should the mentioned identifiers refer to variables? > > * Will another imperative wording be preferred? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=b791d1bdf9212d944d749a5c7ff6febdba241771#n151 > > * I propose to extend the patch a bit more. > How do you think about to convert the initialisation for the variable “ret” > also into a later assignment? Please stop commenting on people's changelogs. You add no value.
Powered by blists - more mailing lists