linux-kernel - Re: [PATCH 2/7] selftests: Remove unneeded selftest API headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200612182105.w22td5jb5g6iltd7@wittgenstein>
Date:   Fri, 12 Jun 2020 20:21:05 +0200
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     Shuah Khan <shuah@...nel.org>,
        Christian Brauner <christian@...uner.io>,
        linux-kselftest@...r.kernel.org,
        Andy Lutomirski <luto@...capital.net>,
        Will Drewry <wad@...omium.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] selftests: Remove unneeded selftest API headers

On Thu, Jun 11, 2020 at 03:40:23PM -0700, Kees Cook wrote:
> Remove unused includes of the kselftest.h header.
> 
> Cc: Christian Brauner <christian@...uner.io>
> Cc: Shuah Khan <shuah@...nel.org>
> Cc: linux-kselftest@...r.kernel.org
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---

Thanks!
Acked-by: Christian Brauner <christian.brauner@...ntu.com>

>  tools/testing/selftests/pid_namespace/regression_enomem.c | 1 -
>  tools/testing/selftests/pidfd/pidfd_getfd_test.c          | 1 -
>  tools/testing/selftests/pidfd/pidfd_setns_test.c          | 1 -
>  tools/testing/selftests/uevent/uevent_filtering.c         | 1 -
>  4 files changed, 4 deletions(-)
> 
> diff --git a/tools/testing/selftests/pid_namespace/regression_enomem.c b/tools/testing/selftests/pid_namespace/regression_enomem.c
> index 73d532556d17..7d84097ad45c 100644
> --- a/tools/testing/selftests/pid_namespace/regression_enomem.c
> +++ b/tools/testing/selftests/pid_namespace/regression_enomem.c
> @@ -11,7 +11,6 @@
>  #include <syscall.h>
>  #include <sys/wait.h>
>  
> -#include "../kselftest.h"
>  #include "../kselftest_harness.h"
>  #include "../pidfd/pidfd.h"
>  
> diff --git a/tools/testing/selftests/pidfd/pidfd_getfd_test.c b/tools/testing/selftests/pidfd/pidfd_getfd_test.c
> index 401a7c1d0312..eecbf18510fd 100644
> --- a/tools/testing/selftests/pidfd/pidfd_getfd_test.c
> +++ b/tools/testing/selftests/pidfd/pidfd_getfd_test.c
> @@ -18,7 +18,6 @@
>  #include <linux/kcmp.h>
>  
>  #include "pidfd.h"
> -#include "../kselftest.h"
>  #include "../kselftest_harness.h"
>  
>  /*
> diff --git a/tools/testing/selftests/pidfd/pidfd_setns_test.c b/tools/testing/selftests/pidfd/pidfd_setns_test.c
> index 133ec5b6cda8..f66861cf9c4d 100644
> --- a/tools/testing/selftests/pidfd/pidfd_setns_test.c
> +++ b/tools/testing/selftests/pidfd/pidfd_setns_test.c
> @@ -20,7 +20,6 @@
>  
>  #include "pidfd.h"
>  #include "../clone3/clone3_selftests.h"
> -#include "../kselftest.h"
>  #include "../kselftest_harness.h"
>  
>  enum {
> diff --git a/tools/testing/selftests/uevent/uevent_filtering.c b/tools/testing/selftests/uevent/uevent_filtering.c
> index f83391aa42cf..5cebfb356345 100644
> --- a/tools/testing/selftests/uevent/uevent_filtering.c
> +++ b/tools/testing/selftests/uevent/uevent_filtering.c
> @@ -19,7 +19,6 @@
>  #include <sys/wait.h>
>  #include <unistd.h>
>  
> -#include "../kselftest.h"
>  #include "../kselftest_harness.h"
>  
>  #define __DEV_FULL "/sys/devices/virtual/mem/full/uevent"
> -- 
> 2.25.1
>