lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 12 Jun 2020 11:41:50 -0700
From:   Kees Cook <>
To:     Christian Brauner <>
Cc:     Shuah Khan <>,
        Greg Kroah-Hartman <>,,
        Christian Brauner <>,
        Andy Lutomirski <>,
        Will Drewry <>,
Subject: Re: [PATCH 3/7] selftests/binderfs: Fix harness API usage

On Fri, Jun 12, 2020 at 08:19:00PM +0200, Christian Brauner wrote:
> On Thu, Jun 11, 2020 at 03:40:24PM -0700, Kees Cook wrote:
> > The binderfs test mixed the full harness API and the selftest API.
> > Adjust to use only the harness API so that the harness API can switch
> > to using the selftest API internally in future patches.
> > 
> > Cc: Shuah Khan <>
> > Cc: Christian Brauner <>
> > Cc: Greg Kroah-Hartman <>
> > Cc:
> > Signed-off-by: Kees Cook <>
> > ---
> I had this on my TODO but never actually got around to it, so thanks!
> In all honesty, I've done a "Does this overall look sane?" review.
> Simply because I lack the time to do this in more detail right now but
> I'm happy this work is done and so overall:
> Acked-by: Christian Brauner <>

I did actually do runtime tests of this (and found a couple bugs in my
port that I fixed before sending the final version). So, fwiw, it passes
for me.

Thanks for the review!


Kees Cook

Powered by blists - more mailing lists