lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 13 Jun 2020 16:59:23 -0500 From: wu000273@....edu To: kjlu@....edu Cc: wu000273@....edu, Michal Simek <michal.simek@...inx.com>, Rob Herring <robh@...nel.org>, Wolfram Sang <wsa@...nel.org>, Shubhrajyoti Datta <shubhraj@...inx.com>, linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH] i2c: xiic: Fix reference count leaks. From: Qiushi Wu <wu000273@....edu> pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails. Fixes: 36ecbcab84d0 ("i2c: xiic: Implement power management") Signed-off-by: Qiushi Wu <wu000273@....edu> --- drivers/i2c/busses/i2c-xiic.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 90c1c362394d..ffec41e6be72 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -696,8 +696,10 @@ static int xiic_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) xiic_getreg8(i2c, XIIC_SR_REG_OFFSET)); err = pm_runtime_get_sync(i2c->dev); - if (err < 0) + if (err < 0) { + pm_runtime_put_noidle(i2c->dev); return err; + } err = xiic_busy(i2c); if (err) @@ -860,8 +862,10 @@ static int xiic_i2c_remove(struct platform_device *pdev) i2c_del_adapter(&i2c->adap); ret = pm_runtime_get_sync(i2c->dev); - if (ret < 0) + if (ret < 0) { + pm_runtime_put_noidle(i2c->dev); return ret; + } xiic_deinit(i2c); pm_runtime_put_sync(i2c->dev); -- 2.17.1
Powered by blists - more mailing lists