linux-kernel - Re: [PATCH] i2c: xiic: Fix reference count leaks.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 14 Jun 2020 11:09:50 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     wu000273@....edu
Cc:     kjlu@....edu, Michal Simek <michal.simek@...inx.com>,
        Rob Herring <robh@...nel.org>,
        Shubhrajyoti Datta <shubhraj@...inx.com>,
        linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: xiic: Fix reference count leaks.

On Sat, Jun 13, 2020 at 04:59:23PM -0500, wu000273@....edu wrote:
> From: Qiushi Wu <wu000273@....edu>
> 
> pm_runtime_get_sync() increments the runtime PM usage counter even
> when it returns an error code. Thus call pm_runtime_put_noidle()
> if pm_runtime_get_sync() fails.

Can you point me to a discussion where it was decided that this is a
proper fix? I'd think we rather should fix pm_runtime_get_sync() but
maybe there are technical reasons against it.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)