linux-kernel - Re: Good idea to rename files in include/uapi/ ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 14 Jun 2020 23:47:15 +0100
From:   Al Viro <viro@...iv.linux.org.uk>
To:     "Alexander A. Klimov" <grandmaster@...klimov.de>
Cc:     Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...filter.org>,
        Florian Westphal <fw@...len.de>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Andrea Parri <parri.andrea@...il.com>,
        Will Deacon <will@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Boqun Feng <boqun.feng@...il.com>,
        Nicholas Piggin <npiggin@...il.com>,
        David Howells <dhowells@...hat.com>,
        Jade Alglave <j.alglave@....ac.uk>,
        Luc Maranget <luc.maranget@...ia.fr>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        Akira Yokosawa <akiyks@...il.com>,
        Daniel Lustig <dlustig@...dia.com>,
        linux-kernel@...r.kernel.org, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org, netdev@...r.kernel.org,
        linux-arch@...r.kernel.org
Subject: Re: Good idea to rename files in include/uapi/ ?

On Sun, Jun 14, 2020 at 09:41:17PM +0200, Alexander A. Klimov wrote:
> Hello there!
> 
> At the moment one can't checkout a clean working directory w/o any changed
> files on a case-insensitive FS as the following file names have lower-case
> duplicates:

And if you use a filesystem that is limited to 14 characters in name (or that
weird 8 + 3 thing) you'll also have problems.  Doctor, it hurts when I do it...

> Also even on a case-sensitive one VIm seems to have trouble with editing
> both case-insensitively equal files at the same time.

So file a bug report against vim.  Or use a vi variant without such a problem
(FWIW, nvi has nothing of that sort).

> I was going to make a patch renaming the respective duplicates, but I'm not
> sure:
> 
> *Is it a good idea to rename files in include/uapi/ ?*

It is not.  Strictly speaking, C99 allows implementation to consider the
header names differing only in case as refering to the same file, but then
it allows to ignore everything between the 8th character and the first
dot in those.  Not done on Unices, so #include <Shite.h> is not going to
pick /usr/include/shite.h

If it's used by any userland code, that's it - changing the name (in any fashion)
will break that userland code.  If it isn't, it shouldn't have been in include/uabi
in the first place.