linux-kernel - Re: [PATCH v1] ARM: bcm2835: Fix integer overflow in rpi_firmware_print_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e504c53d632b4f175f69782d1e38f0030dc9055.camel@suse.de>
Date:   Tue, 16 Jun 2020 18:42:00 +0200
From:   Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Cc:     Stefan Wahren <wahrenst@....net>, Petr Mladek <pmladek@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [PATCH v1] ARM: bcm2835: Fix integer overflow in
 rpi_firmware_print_firmware_revision()

On Tue, 2020-06-16 at 19:31 +0300, Andy Shevchenko wrote:
> time64_t is 64-bit width type, we are not supposed to supply lesser ones
> as in the case of rpi_firmware_print_firmware_revision() after the commit
> 4a60f58ee002 ("ARM: bcm2835: Switch to use %ptT"). Use temporary variable
> of time64_t type to correctly handle lesser types.
> 
> Fixes: 4a60f58ee002 ("ARM: bcm2835: Switch to use %ptT")
> Reported-by: Stefan Wahren <wahrenst@....net>
> Reported-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Cc: Petr Mladek <pmladek@...e.com>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> ---

Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
Tested-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>

If this doesn't fit the printk tree I don't mind taking it trough the rpi soc
tree.

I'll also update the MAINTAINERS file so the firmware driver isn't orphaned.

Thanks!
Nicolas


Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)