linux-kernel - Re: [PATCH v1 RFC 1/2] spi: introduce fallback to pio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200616095948.GJ4447@sirena.org.uk>
Date:   Tue, 16 Jun 2020 10:59:48 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Robin Gong <yibin.gong@....com>
Cc:     Vinod Koul <vkoul@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "robin.murphy@....com" <robin.murphy@....com>,
        "matthias.schiffer@...tq-group.com" 
        <matthias.schiffer@...tq-group.com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>,
        "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 RFC 1/2] spi: introduce fallback to pio

On Tue, Jun 16, 2020 at 02:03:40AM +0000, Robin Gong wrote:
> On 2020/06/15 22:56 Mark Brown <broonie@...nel.org> wrote: 

>         struct list_head transfer_list;
> +
> +#define        SPI_TRANS_DMA_PREP_FAIL BIT(3)  /* prepare dma failed */
> +       u16             flags;

I'd just make this a generic flag for failures before we start
interacting with the hardware rather than specifically this one error
case.  Otherwise this looks fine.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)