linux-kernel - Re: [PATCH v3] drm/panfrost: Reduce the amount of logs on deferred probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqLrFFOVQVR0dWbru6bJvz7sXs8v6Op-hiNgdMwH3N=2Fw@mail.gmail.com>
Date:   Wed, 17 Jun 2020 13:57:40 -0600
From:   Rob Herring <robh@...nel.org>
To:     Steven Price <steven.price@....com>
Cc:     Krzysztof Kozlowski <krzk@...nel.org>,
        Tomeu Vizoso <tomeu.vizoso@...labora.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Alyssa Rosenzweig <alyssa.rosenzweig@...labora.com>
Subject: Re: [PATCH v3] drm/panfrost: Reduce the amount of logs on deferred probe

On Wed, Jun 17, 2020 at 8:36 AM Steven Price <steven.price@....com> wrote:
>
> On 17/06/2020 15:15, Krzysztof Kozlowski wrote:
> > On Wed, May 27, 2020 at 04:43:34PM -0400, Alyssa Rosenzweig wrote:
> >> Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@...labora.com>
> >>
> >> On Wed, May 27, 2020 at 10:05:44PM +0200, Krzysztof Kozlowski wrote:
> >>> There is no point to print deferred probe (and its failures to get
> >>> resources) as an error.  Also there is no need to print regulator errors
> >>> twice.
> >>>
> >>> In case of multiple probe tries this would pollute the dmesg.
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> >>> Reviewed-by: Steven Price <steven.price@....com>
> >>>
> >>> ---
> >>>
> >>> Changes since v2:
> >>> 1. Rebase
> >>> 2. Add Steven's review
> >>>
> >>> Changes since v1:
> >>> 1. Remove second error message from calling panfrost_regulator_init()
> >>> ---
> >>>   drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++----
> >>>   1 file changed, 4 insertions(+), 4 deletions(-)
> >>>
> >
> > Hi Rob, Tomeu and Steven,
> >
> > You're listed as maintainers for panfrost. Is anyone going to pick this
> > up?
>
> I'm only a reviewer so I've been leaving it for Rob or Tomeu, but I can
> pick it up if Rob/Tomeu are happy for me to do that.
>
> > Maybe I sent it to wrong mailing list or forgot about anything?
>
> No, there's actually a few Panfrost commits waiting, it was on my todo
> list to ask if Rob/Tomeu needed some help with merging patches.

Please do, I haven't had the cycles for panfrost lately.

Rob