linux-kernel - Re: [PATCH] tools/thermal: tmon: include pthread and time headers in tmon.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f5e160e0-ac4f-8c14-d06e-38f859690ff9@gmail.com>
Date:   Wed, 17 Jun 2020 19:52:51 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Markus Mayer <markus.mayer@...adcom.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Sumeet Pawnikar <sumeet.r.pawnikar@...el.com>,
        Zhang Rui <rui.zhang@...el.com>,
        Brian Norris <computersforpeace@...il.com>
Cc:     Broadcom Kernel List <bcm-kernel-feedback-list@...adcom.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tools/thermal: tmon: include pthread and time headers in
 tmon.h



On 6/17/2020 4:58 PM, Markus Mayer wrote:
> Include sys/time.h and pthread.h in tmon.h, so that types
> "pthread_mutex_t" and "struct timeval tv" are known when tmon.h
> references them.
> 
> Without these headers, compiling tmon against musl-libc will fail with
> these errors:
> 
> In file included from sysfs.c:31:0:
> tmon.h:47:8: error: unknown type name 'pthread_mutex_t'
>  extern pthread_mutex_t input_lock;
>         ^~~~~~~~~~~~~~~
> make[3]: *** [<builtin>: sysfs.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> In file included from tui.c:31:0:
> tmon.h:54:17: error: field 'tv' has incomplete type
>   struct timeval tv;
>                  ^~
> make[3]: *** [<builtin>: tui.o] Error 1
> make[2]: *** [Makefile:83: tmon] Error 2
> 
> Signed-off-by: Markus Mayer <mmayer@...adcom.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian