linux-kernel - RE: [PATCH] tools/thermal: tmon: include pthread and time headers in tmon.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3C3E65E75D9910479323816378A812E7417797A2@BGSMSX104.gar.corp.intel.com>
Date:   Tue, 23 Jun 2020 17:17:53 +0000
From:   "Pawnikar, Sumeet R" <sumeet.r.pawnikar@...el.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Markus Mayer <markus.mayer@...adcom.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        "Zhang, Rui" <rui.zhang@...el.com>,
        Brian Norris <computersforpeace@...il.com>
CC:     Broadcom Kernel List <bcm-kernel-feedback-list@...adcom.com>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] tools/thermal: tmon: include pthread and time headers
 in tmon.h

> -----Original Message-----
> From: Florian Fainelli <f.fainelli@...il.com>
> Sent: Thursday, June 18, 2020 8:23 AM
> To: Markus Mayer <markus.mayer@...adcom.com>; Daniel Lezcano
> <daniel.lezcano@...aro.org>; Pawnikar, Sumeet R
> <sumeet.r.pawnikar@...el.com>; Zhang, Rui <rui.zhang@...el.com>; Brian
> Norris <computersforpeace@...il.com>
> Cc: Broadcom Kernel List <bcm-kernel-feedback-list@...adcom.com>; Linux
> Kernel Mailing List <linux-kernel@...r.kernel.org>
> Subject: Re: [PATCH] tools/thermal: tmon: include pthread and time headers
> in tmon.h
> 
> 
> 
> On 6/17/2020 4:58 PM, Markus Mayer wrote:
> > Include sys/time.h and pthread.h in tmon.h, so that types
> > "pthread_mutex_t" and "struct timeval tv" are known when tmon.h
> > references them.
> >
> > Without these headers, compiling tmon against musl-libc will fail with
> > these errors:
> >
> > In file included from sysfs.c:31:0:
> > tmon.h:47:8: error: unknown type name 'pthread_mutex_t'
> >  extern pthread_mutex_t input_lock;
> >         ^~~~~~~~~~~~~~~
> > make[3]: *** [<builtin>: sysfs.o] Error 1
> > make[3]: *** Waiting for unfinished jobs....
> > In file included from tui.c:31:0:
> > tmon.h:54:17: error: field 'tv' has incomplete type
> >   struct timeval tv;
> >                  ^~
> > make[3]: *** [<builtin>: tui.o] Error 1
> > make[2]: *** [Makefile:83: tmon] Error 2
> >
> > Signed-off-by: Markus Mayer <mmayer@...adcom.com>
> 
> Acked-by: Florian Fainelli <f.fainelli@...il.com>
> --
> Florian

Reviewed-by: Sumeet Pawnikar <sumeet.r.pawnikar@...el.com>

Thanks,
Sumeet.