linux-kernel - RE: [PATCH] tools/thermal: tmon: include pthread and time headers in tmon.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun,  9 Aug 2020 14:57:20 +0200
From:   Alejandro González 
        <alejandro.gonzalez.correo@...il.com>
To:     f.fainelli@...il.com, markus.mayer@...adcom.com,
        daniel.lezcano@...aro.org, rui.zhang@...el.com,
        computersforpeace@...il.com
Cc:     bcm-kernel-feedback-list@...adcom.com,
        linux-kernel@...r.kernel.org,
        Alejandro González 
        <alejandro.gonzalez.correo@...il.com>
Subject: RE: [PATCH] tools/thermal: tmon: include pthread and time headers in tmon.h

> > -----Original Message-----
> > From: Florian Fainelli <f.fainelli@...il.com>
> > Sent: Thursday, June 18, 2020 8:23 AM
> > To: Markus Mayer <markus.mayer@...adcom.com>; Daniel Lezcano
> > <daniel.lezcano@...aro.org>; Pawnikar, Sumeet R
> > <sumeet.r.pawnikar@...el.com>; Zhang, Rui <rui.zhang@...el.com>; Brian
> > Norris <computersforpeace@...il.com>
> > Cc: Broadcom Kernel List <bcm-kernel-feedback-list@...adcom.com>; Linux
> > Kernel Mailing List <linux-kernel@...r.kernel.org>
> > Subject: Re: [PATCH] tools/thermal: tmon: include pthread and time headers
> > in tmon.h
> > 
> > 
> > 
> > On 6/17/2020 4:58 PM, Markus Mayer wrote:
> > > Include sys/time.h and pthread.h in tmon.h, so that types
> > > "pthread_mutex_t" and "struct timeval tv" are known when tmon.h
> > > references them.
> > >
> > > Without these headers, compiling tmon against musl-libc will fail with
> > > these errors:
> > >
> > > In file included from sysfs.c:31:0:
> > > tmon.h:47:8: error: unknown type name 'pthread_mutex_t'
> > >  extern pthread_mutex_t input_lock;
> > >         ^~~~~~~~~~~~~~~
> > > make[3]: *** [<builtin>: sysfs.o] Error 1
> > > make[3]: *** Waiting for unfinished jobs....
> > > In file included from tui.c:31:0:
> > > tmon.h:54:17: error: field 'tv' has incomplete type
> > >   struct timeval tv;
> > >                  ^~
> > > make[3]: *** [<builtin>: tui.o] Error 1
> > > make[2]: *** [Makefile:83: tmon] Error 2
> > >
> > > Signed-off-by: Markus Mayer <mmayer@...adcom.com>
> > 
> > Acked-by: Florian Fainelli <f.fainelli@...il.com>
> > --
> > Florian
> 
> Reviewed-by: Sumeet Pawnikar <sumeet.r.pawnikar@...el.com>
> 
> Thanks,
> Sumeet.

I've tested this patch with musl-libc for the same arch. It works like a charm.

Acked-by: Alejandro González <alejandro.gonzalez.correo@...il.com>
Tested-by: Alejandro González <alejandro.gonzalez.correo@...il.com>