lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Jun 2020 09:27:42 -0500 From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com> To: Vinod Koul <vkoul@...nel.org>, Takashi Iwai <tiwai@...e.com>, Jaroslav Kysela <perex@...ex.cz> Cc: Charles Keepax <ckeepax@...nsource.cirrus.com>, alsa-devel@...a-project.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/3] ALSA: compress: document the compress gapless audio state machine > +For Gapless, we move from running state to partial drain and back, along > +with setting of meta_data and signalling for next track :: > + > + > + +----------+ > + compr_drain_notify() | | > + +------------------------>| RUNNING | > + | | | > + | +----------+ > + | | > + | | > + | | compr_next_track() > + | | > + | V > + | +----------+ > + | | | > + | |NEXT_TRACK| > + | | | > + | +----------+ > + | | > + | | > + | | compr_partial_drain() > + | | > + | V > + | +----------+ > + | | | > + +------------------------ | PARTIAL_ | > + | DRAIN | > + +----------+ May I suggest having a single state machine, not a big one and an additional partial one. It would help explain why in one case compr_drain_notify() triggers a transition to RUNNING while in the other one it goes to SETUP. I realize it's more complicated to edit but it'd be easier on reviewers/users.
Powered by blists - more mailing lists