| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <8e322574-14bc-aaaa-5fdb-751cb8b97fff@linux.intel.com>
Date: Fri, 19 Jun 2020 09:22:09 -0500
From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To: Vinod Koul <vkoul@...nel.org>, Takashi Iwai <tiwai@...e.com>,
Jaroslav Kysela <perex@...ex.cz>
Cc: Charles Keepax <ckeepax@...nsource.cirrus.com>,
alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] ALSA: compress: document the compress audio state
machine
> +
> + +----------+
> + | |
> + | OPEN |
> + | |
> + +----------+
> + |
> + |
> + | compr_set_params()
> + |
> + V
> + +----------+
> + compr_drain_notify() | |
> + +------------------------>| SETUP |
> + | | |
> + | +----------+
> + | |
> + | |
> + | | compr_write()
> + | |
> + | V
> + | +----------+
> + | | |
> + | | PREPARE |
> + | | |
> + | +----------+
> + | |
> + | |
> + | | compr_start()
> + | |
> + | V
> + +----------+ +----------+ compr_pause() +----------+
> + | | | |----------------------->| |
> + | DRAIN |<-------------------| RUNNING | | PAUSE |
> + | | | |<-----------------------| |
> + +----------+ +----------+ compr_resume() +----------+
> + | |
> + | |
> + | | compr_free()
> + | |
> + | V
> + | +----------+
> + | compr_free() | |
> + +------------------------>| |
> + | STOP |
> + | |
> + +----------+
The STOP state doesn't seem quite right to me, sorry.
the direction of the DRAIN-STOP comp_free() arrow seems wrong? Of if it
is correct, then something's missing to exit the STOP state so that the
stream can be opened again.
Powered by blists - more mailing lists